Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow crs as class name to match projection #1332

Merged
merged 8 commits into from
May 2, 2024
Merged

Conversation

ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Apr 29, 2024

Closes #1303

import xarray as xr
import hvplot.xarray

ds = xr.tutorial.open_dataset("air_temperature").isel(time=0)
ds.hvplot("lon", "lat", projection="PlateCarree", crs="PlateCarree")
image

@ahuang11 ahuang11 changed the title Allow crs as class name Allow crs as class name to match projection Apr 29, 2024
@ahuang11 ahuang11 added the type: enhancement New feature or request label Apr 29, 2024
@ahuang11 ahuang11 requested a review from maximlt April 30, 2024 14:58
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this needs to be updated:

https://github.com/holoviz/hvplot/pull/1332/files#diff-784450df58c4440b52a1431a7402766102b3d56ad7f1fbc30a4ff2c2fef24352R317-R320

Together with the project/crs docstring in the converter and the doc in the geographic user guide and customization guide.

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.36%. Comparing base (e5e71d6) to head (c15317f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1332   +/-   ##
=======================================
  Coverage   87.36%   87.36%           
=======================================
  Files          50       50           
  Lines        7471     7472    +1     
=======================================
+ Hits         6527     6528    +1     
  Misses        944      944           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahuang11 ahuang11 requested a review from maximlt May 1, 2024 01:15
@maximlt
Copy link
Member

maximlt commented May 2, 2024

Thanks!!!

@maximlt maximlt merged commit 769bd14 into main May 2, 2024
9 of 10 checks passed
@maximlt maximlt deleted the allow_crs_as_class_name branch May 2, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align the values/types accepted by crs and projection
2 participants