Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix .hist for ibis backend #997

Merged
merged 13 commits into from
Oct 10, 2023
Merged

Fix .hist for ibis backend #997

merged 13 commits into from
Oct 10, 2023

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Dec 1, 2022

Closes #996

Depends on #990.

@MarcSkovMadsen MarcSkovMadsen marked this pull request as ready for review December 1, 2022 19:55
Copy link
Member

@maximlt maximlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Marc. I don't know much about ibis. Is it meant to provide a single interface to various backends? If so, we should probably stick to a single interface as otherwise we would just be testing ibis itself, not hvPlot.

hvplot/tests/testibis.py Outdated Show resolved Hide resolved
hvplot/tests/testibis.py Outdated Show resolved Hide resolved
hvplot/tests/testibis.py Outdated Show resolved Hide resolved
hvplot/tests/testibis.py Outdated Show resolved Hide resolved
hvplot/tests/testibis.py Outdated Show resolved Hide resolved
hvplot/tests/testibis.py Outdated Show resolved Hide resolved
@maximlt maximlt added this to the 0.9.0 milestone Sep 11, 2023
@maximlt maximlt self-requested a review October 2, 2023 08:25
@maximlt
Copy link
Member

maximlt commented Oct 10, 2023

Thanks for fixing that @MarcSkovMadsen. I greatly simplified the tests for this PR, I want to revisit the hvPlot test suite later to define a base series of tests that should be run for all supported data structures.

There's still a lot of work required to get Ibis fully supported in hvPlot so it's going to be marked as experimental.

@maximlt maximlt merged commit 20790bd into main Oct 10, 2023
7 checks passed
@maximlt maximlt deleted the fix/hist branch October 10, 2023 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hvplot.hist with ibis+duckdb: ValueError: The truth value of an Ibis expression is not defined
3 participants