-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix .hist for ibis backend #997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Marc. I don't know much about ibis. Is it meant to provide a single interface to various backends? If so, we should probably stick to a single interface as otherwise we would just be testing ibis itself, not hvPlot.
Thanks for fixing that @MarcSkovMadsen. I greatly simplified the tests for this PR, I want to revisit the hvPlot test suite later to define a base series of tests that should be run for all supported data structures. There's still a lot of work required to get Ibis fully supported in hvPlot so it's going to be marked as experimental. |
Closes #996
Depends on #990.