Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mapping for switchbot meter pro #128947

Closed
wants to merge 3 commits into from
Closed

Add mapping for switchbot meter pro #128947

wants to merge 3 commits into from

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Oct 21, 2024

Proposed change

Add Meter Pro support to SwitchBot (The version with CO2 support works but temp/humid only as we do not know how to decode the CO2 value yet)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Danielhiversen, @RenierM26, @murtas, @Eloston, @dsypniewski, mind taking a look at this pull request as it has been labeled with an integration (switchbot) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switchbot can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign switchbot Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bdraco bdraco force-pushed the pyswitch_meter_pro branch from 11e508c to bb3128e Compare October 21, 2024 22:19
@bdraco bdraco marked this pull request as ready for review October 22, 2024 03:11
@bdraco bdraco marked this pull request as draft October 22, 2024 04:29
@bdraco
Copy link
Member Author

bdraco commented Oct 22, 2024

drafting for one more lib bump since the CO2 model can be added now even though we don't know how to decode the CO2 value yet .. it will still get temp and humid support

#128953

@bdraco bdraco force-pushed the pyswitch_meter_pro branch from bb3128e to 8f99b3f Compare October 22, 2024 15:55
@bdraco bdraco marked this pull request as ready for review October 22, 2024 16:12
bdraco added a commit that referenced this pull request Oct 22, 2024
@bdraco bdraco mentioned this pull request Oct 22, 2024
19 tasks
@bdraco
Copy link
Member Author

bdraco commented Oct 22, 2024

closing in favor of #128991

@bdraco bdraco closed this Oct 22, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants