Xiaomi MiIO Switch: Support for the Xiaomi Chuangmi Plug V3 #13271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rytilahti
reviewed
Mar 16, 2018
| plug = PlugV3(host, token) | ||
| else: | ||
| from miio import PlugV1 | ||
| plug = PlugV1(host, token) |
There was a problem hiding this comment.
With python-miio maintainer hat on, should we try to merge PlugV1 and PlugV3 into one class (and allow specifying the type with an enum)?
edit: to add, otherwise this looks fairly straight-forward and good to me.
There was a problem hiding this comment.
Let's merge both devices into one class! 👍
There was a problem hiding this comment.
Ok, great! This depends on rytilahti/python-miio#270 and a new version of python-miio then, I'll mark it as a WIP.
rytilahti
changed the title
|
I've merged all plugs into one class. The change is part of python-miio 0.3.9. I will rebase this PR as soon the version bump is merged. |
syssi
force-pushed
the
feature/xiaomi-miio-switch-chuangmi-v3
branch
from
0e9d63c to
a9178fb
Compare
syssi
changed the title
|
Looks good to me, tested to work with |
Merged
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Chuangmi V3 is very similar to the V1.
New features: The WiFi LED can be toggled and it reports the power consumption of the AC power outlet.