Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register xiaomi_miio unload callbacks later in setup #76714

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

starkillerOG
Copy link
Contributor

Breaking change

Proposed change

Move update listener registration to the end of the setup in order to avoid re-auth flows triggering update listener OperationNotAllowed.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

This pull request needs to be manually signed off by @home-assistant/core before it can get merged.
(message by ReviewEnforcer)

@probot-home-assistant
Copy link

Hey there @rytilahti, @syssi, @bieniu, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the fix for several of the recent issues? If yes, please fill the fixes section of the description, and let's schedule this then for the next point release.

@starkillerOG
Copy link
Contributor Author

@rytilahti no I don't think this is actually causing the real issues with not beeing able to set up the integration.
I think this is only causing errors in the log, but I am not sure.
We schould in any case merge this and see if it helps, but I think more is going on than just this.

@starkillerOG
Copy link
Contributor Author

@rytilahti can you approve/merge this?

@rytilahti rytilahti changed the title Xiaomi Miio move update_listener after re-auth flow Register xiaomi_miio unload callbacks later in setup Sep 2, 2022
Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no reason not to merge this, so let's get it done. Thanks 👍

@rytilahti rytilahti merged commit b49d47a into home-assistant:dev Sep 2, 2022
@MartinHjelmare MartinHjelmare added this to the 2022.9.0 milestone Sep 3, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants