Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support xiaomi_miio Smartmi Air Purifier (zhimi.airpurifier.za1) #80387

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

an0nfunc
Copy link
Contributor

@an0nfunc an0nfunc commented Oct 15, 2022

Proposed change

This PR adds support for Smartmi Air Purifier (zhimi.airpurifier.za1) added in python-miio 0.5.12 (rytilahti/python-miio#1417).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hi an0nfunc

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@home-assistant
Copy link

Hey there @rytilahti, @syssi, @starkillerOG, @bieniu, mind taking a look at this pull request as it has been labeled with an integration (xiaomi_miio) you are listed as a code owner for? Thanks!

@MartinHjelmare MartinHjelmare changed the title [components/xiaomi_miio] Added support for Smartmi Air Purifier (zhimi.airpurifier.za1) Support xiaomi_miio Smartmi Air Purifier (zhimi.airpurifier.za1) Oct 15, 2022
Copy link
Member

@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not able to test the change but the code looks good 👍

Copy link
Member

@rytilahti rytilahti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me from the surface too, thanks @an0nfunc!

The proper long term solution I have been working on involves rytilahti/python-miio#1495 and rytilahti/python-miio#1581 – any help with those two issues, be it annotating the existing integrations or testing the generic miot implementation against a real device, would be awesome.

@an0nfunc
Copy link
Contributor Author

@rytilahti Sounds like the next logical step, I agree. I'll have a look when I find some time.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @an0nfunc 👍

@frenck frenck merged commit a5890b2 into home-assistant:dev Nov 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants