-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support xiaomi_miio Smartmi Air Purifier (zhimi.airpurifier.za1) #80387
Conversation
Hi an0nfunc It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
Hey there @rytilahti, @syssi, @starkillerOG, @bieniu, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not able to test the change but the code looks good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me from the surface too, thanks @an0nfunc!
The proper long term solution I have been working on involves rytilahti/python-miio#1495 and rytilahti/python-miio#1581 – any help with those two issues, be it annotating the existing integrations or testing the generic miot implementation against a real device, would be awesome.
@rytilahti Sounds like the next logical step, I agree. I'll have a look when I find some time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @an0nfunc 👍
Proposed change
This PR adds support for Smartmi Air Purifier (zhimi.airpurifier.za1) added in python-miio 0.5.12 (rytilahti/python-miio#1417).
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: