Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web configuration does not accept "0" as input for custom parameters #332

Closed
luebbe opened this issue May 3, 2017 · 3 comments
Closed
Labels

Comments

@luebbe
Copy link
Collaborator

luebbe commented May 3, 2017

I was trying to configure https://github.com/mhaack/mqtt-bme280-homie with the web frontend at http://setup.homie-esp8266.marvinroger.fr/

On the last page the web frontend showed me the two custom parameter defined for https://github.com/mhaack/mqtt-bme280-homie:
sensorInterval long
temperatureOffset double

The following problems occured:

  • The "next" button of the web frontend stayed disabled when I entered 0 or 0.0 for temperatureOffset.
  • When I entered 1 for the temperature offset, "next" was enabled, I could send the configuration, but it was rejected, because 1 was not a float value. 1.0 was accepted.
  • In order get a "close to" zero offset for the temperature, I had to enter 0.01 instead.
@MTJoker
Copy link

MTJoker commented May 15, 2017

I ran across that problem too. Entering 0 for a custom setting does not enable the next button.

@marvinroger
Copy link
Member

For the second problem, please update ArduinoJson to 5.10.0. I'll fix the first issue!

@marvinroger
Copy link
Member

Fixed in homieiot/homie-esp8266-setup@c8f325e

Feel free to reopen if you still have the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants