Accept three arguments into Sidekiq error handler #495
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting with Sidekiq 7.1.5 the error handler is passed three arguments. The new argument is the Sidekiq config. The `_config` key from the second argument has been removed. Support for passing two arguments and expecting the `_config` is still supported but will raise a deprication warning and will be removed in Sidekiq 8. This change adds an optional third argument to the error handler lambda defaulted to `Sidekiq.default_configuration` as per the Sidekiq changelog on how to handle this. This should make the gem forwards compatible with Sidekiq 8 (excluding any other breaking changes). Sidekiq PR introducing this change: sidekiq/sidekiq#6051
This was referenced Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #493
Starting with Sidekiq 7.1.5 the error handler is passed three arguments. The new argument is the Sidekiq config. The
_configkey from the second argument has been removed.Support for passing two arguments and expecting the
_configis still supported but will raise a deprication warning and will be removed in Sidekiq 8.This change adds an optional third argument to the error handler lambda defaulted to
Sidekiq.default_configurationas per the Sidekiq changelog on how to handle this.This should make the gem forwards compatible with Sidekiq 8 (excluding any other breaking changes).
Sidekiq PR introducing this change: sidekiq/sidekiq#6051