Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept three arguments into Sidekiq error handler #495

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Accept three arguments into Sidekiq error handler #495

merged 1 commit into from
Oct 16, 2023

Commits on Oct 14, 2023

  1. Accept three arguments into Sidekiq error handler 

    Starting with Sidekiq 7.1.5 the error handler is passed three arguments. The new argument is the Sidekiq config. The `_config` key from the second argument has been removed.

Support for passing two arguments and expecting the `_config` is still supported but will raise a deprication warning and will be removed in Sidekiq 8.

This change adds an optional third argument to the error handler lambda defaulted to `Sidekiq.default_configuration` as per the Sidekiq changelog on how to handle this.

This should make the gem forwards compatible with Sidekiq 8 (excluding any other breaking changes).

Sidekiq PR introducing this change: sidekiq/sidekiq#6051
    @t27duck
    t27duck committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    860bb7b View commit details
    Browse the repository at this point in the history