Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Make notify work with proper ruby keyword arguments #498

Merged
merged 4 commits into from
Oct 19, 2023
Merged

FIX: Make notify work with proper ruby keyword arguments #498

merged 4 commits into from
Oct 19, 2023

Conversation

halfbyte
Copy link
Contributor

@halfbyte halfbyte commented Oct 19, 2023 •
edited
Loading

Fixes #426, at least as reported.

I have not looked through docs and code to see if there are more method signatures that should be fixed.

@halfbyte halfbyte marked this pull request as ready for review October 19, 2023 16:26
@halfbyte
Fix docs
87fe569 
Removed the hash braces in the second example to clarify that kwargs are fine
@stympy stympy requested a review from joshuap October 19, 2023 19:49
joshuap
joshuap approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@joshuap joshuap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks! I made a few small changes.

@joshuap joshuap merged commit e4a006c into master Oct 19, 2023
58 checks passed
@joshuap joshuap deleted the issue-426-notify-kwargs branch October 19, 2023 22:22
@subzero10 subzero10 mentioned this pull request Oct 27, 2023
Merged
@github-actions github-actions bot mentioned this pull request Oct 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshuap joshuap joshuap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Correctly support Ruby 2.7+ keyword arguments.
2 participants
@halfbyte @joshuap