Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): missing response type on OnHandlerInterface #3852

Merged
merged 1 commit into from
Jan 25, 2025

Conversation

sor4chi
Copy link
Contributor

@sor4chi sor4chi commented Jan 25, 2025

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code

Copy link

codecov bot commented Jan 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.32%. Comparing base (ecf5a0b) to head (f15e391).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3852   +/-   ##
=======================================
  Coverage   91.32%   91.32%           
=======================================
  Files         161      161           
  Lines       10242    10242           
  Branches     2891     2863   -28     
=======================================
  Hits         9353     9353           
  Misses        888      888           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sor4chi sor4chi marked this pull request as ready for review January 25, 2025 06:00
@yusukebe yusukebe changed the title fix: missing response type on OnHandlerInterface fix(types): missing response type on OnHandlerInterface Jan 25, 2025
Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@sor4chi

Thanks! This should be fixed. I'll merge this.

@yusukebe yusukebe merged commit d75e9ec into honojs:main Jan 25, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants