fix(lambda-edge-adapter): Support Alternate Domain Names and Multiple Cookies in Lambda@Edge #3858
+93
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 26, 2025 21:15
Previously, only the CloudFront distribution name was used. Now, the Host header value is utilized for more accurate detection.
Previously, only the last Set-Cookie header was returned. This update ensures all Set-Cookie headers are processed and returned as expected.
|
Thanks @kentkwee ! The CI is falling. Can you take a look? Hey @watany-dev Can you review this? |
|
Sorry for the oversight. Wasn't aware that |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3858 +/- ##
==========================================
+ Coverage 91.32% 91.33% +0.01%
==========================================
Files 161 162 +1
Lines 10242 10263 +21
Branches 2889 2941 +52
==========================================
+ Hits 9353 9374 +21
Misses 888 888
Partials 1 1 ☔ View full report in Codecov by Sentry. |
|
Hi @kentkwee ! Looks good to me. I'll merge it now. Thank you! |
|
No problem. Thank you for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces support for using alternate domain names in front of a CloudFront distribution. Additionally, it enhances cookie handling by supporting the setting of multiple cookies, addressing the previous limitation where only the last cookie was set.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code