fix(serve): support ipv6 by default #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For node's server.listen, if no hostname param is specified it'll adaptively pick the unspecified ipv6 address (`::`) when available or the unspecified ipv4 address (`0.0.0.0`) otherwise. This fix gets rid of the behavior where we manually default to `0.0.0.0` and rely on node's underlying handling of this. See here for the docs on node: https://nodejs.org/api/net.html#serverlistenport-host-backlog-callback:~:text=If%20host%20is%20omitted%2C%20the%20server%20will%20accept%20connections%20on%20the%20unspecified%20IPv6%20address%20(%3A%3A)%20when%20IPv6%20is%20available%2C%20or%20the%20unspecified%20IPv4%20address%20(0.0.0.0)%20otherwise.
|
Hi @sinasab Nice fix! Thank you. I'll merge it and release a new version. |
sinasab
added a commit
to sinasab/ponder
that referenced
this pull request
Oct 10, 2024
See context here: ponder-sh#1146 Upstream change to hono/node-server was included @ honojs/node-server#206 This PR bumps the version of hono/node-server to include the upstream change. I also added a test to ensure ipv6 works, which should help avoid future regressions as well!
sinasab
added a commit
to sinasab/ponder
that referenced
this pull request
Oct 10, 2024
See context here: ponder-sh#1146 Upstream change to hono/node-server was included @ honojs/node-server#206 This PR bumps the version of hono/node-server to include the upstream change. I also added a test to ensure ipv6 works, which should help avoid future regressions as well!
kyscott18
pushed a commit
to ponder-sh/ponder
that referenced
this pull request
Oct 10, 2024
* chore: bumping hono/node-server to support ipv6 See context here: #1146 Upstream change to hono/node-server was included @ honojs/node-server#206 This PR bumps the version of hono/node-server to include the upstream change. I also added a test to ensure ipv6 works, which should help avoid future regressions as well! * Update stupid-cooks-wash.md --------- Co-authored-by: typedarray <90073088+0xOlias@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For node's server.listen, if no hostname param is specified it'll adaptively pick the unspecified ipv6 address (
::) when available or the unspecified ipv4 address (0.0.0.0) otherwise. This fix gets rid of the behavior where we manually default to0.0.0.0and rely on node's underlying handling of this.Since most modern systems should support ipv6, I also added a test case on this new behavior.
See here for the docs on node: https://nodejs.org/api/net.html#serverlistenport-host-backlog-callback:~:text=If%20host%20is%20omitted%2C%20the%20server%20will%20accept%20connections%20on%20the%20unspecified%20IPv6%20address%20(%3A%3A)%20when%20IPv6%20is%20available%2C%20or%20the%20unspecified%20IPv4%20address%20(0.0.0.0)%20otherwise.