Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detection of client premature close #218

Merged
merged 4 commits into from
Nov 12, 2024
Merged

fix: detection of client premature close #218

merged 4 commits into from
Nov 12, 2024

Conversation

Tomas2D
Copy link
Contributor

@Tomas2D Tomas2D commented Nov 9, 2024 •
edited
Loading

Fix detection client premature close (connection abort).

Ref: #217

@Tomas2D
fix: detection of client premature close
48b0e15 
Ref: honojs#217
Signed-off-by: Tomas Dvorak <toomas2d@gmail.com>
@usualoma usualoma mentioned this pull request Nov 10, 2024
Closed
@Tomas2D
fix: improve detection of client premature close
3e9ea8d 
Ref: honojs#217
Signed-off-by: Tomas Dvorak <toomas2d@gmail.com>
usualoma
usualoma reviewed Nov 11, 2024
View reviewed changes
Copy link
Member

@usualoma usualoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, that's great 👍
I have made one comment, so please check it.

test/listener.test.ts Outdated Show resolved Hide resolved
@Tomas2D
fixup! fix: improve detection of client premature close
4139443 
Ref: honojs#217
Signed-off-by: Tomas Dvorak <toomas2d@gmail.com>
usualoma
usualoma approved these changes Nov 11, 2024
View reviewed changes
Copy link
Member

@usualoma usualoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM 👍

@yusukebe
Copy link
Member

Hi @Tomas2D !

To make CI pass, run the command yarn lint && yarn format to format the code.

@Tomas2D
fixup! fixup! fix: improve detection of client premature close
c8aea93 
Ref: honojs#217
Signed-off-by: Tomas Dvorak <toomas2d@gmail.com>
@Tomas2D
Copy link
Contributor Author

Tomas2D commented Nov 12, 2024

Updated. @yusukebe 👋🏻

@yusukebe
Copy link
Member

@Tomas2D

Thanks! Looks good to me. Merging.

@yusukebe yusukebe merged commit 2fdcdad into honojs:main Nov 12, 2024
3 checks passed
@Tomas2D Tomas2D deleted the fix/217-client-premature-close branch November 12, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@usualoma usualoma usualoma approved these changes

@yusukebe yusukebe yusukebe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Tomas2D @yusukebe @usualoma