Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on deno #189

Open
mcandeia opened this issue Oct 23, 2024 · 2 comments
Open

Does not work on deno #189

mcandeia opened this issue Oct 23, 2024 · 2 comments

Comments

@mcandeia
Copy link

  1. Checkout the repo: https://github.com/mcandeia/hono-vite-dev-server-deno-repro-issue.git (started from https://remix.run/docs/en/main/guides/vite#getting-started)
  2. run deno install
  3. run deno run dev
  4. make a request and check that the headers are always empty

e.g:

curl "http://localhost:5173" -H 'X-Custom-Header: value'
@yusukebe
Copy link
Member

Hi @mcandeia

I think this is not a @hono/vite-dev-server matter. This may be a Remix or hono-remix-adapter issue, but I'm not sure Remix fully supports Deno.

@mcandeia
Copy link
Author

mcandeia commented Nov 6, 2024

It does support @yusukebe I've been running remix + Deno2.0 succesfully in production since deno2 release. But you might be right, it could be somehow related to hono/node-server. instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants