Upgrade money gem support to ~> 6.7 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So this updates this library, and seems minor. Have you created branches for the Money gem update in other repos (specifically the main app will need it as it uses this library). |
|
LGTM @chaslemley @chris. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
money ~> 4is incompatible with currentmoneyversions that are used by some our dependencies. To resolve this problem I've upgraded dependency tomoney ~ 6.7and refreshed specs based onupgrade_to_money_5branch.@chris @chaslemley @rosic I understand that you may be currently using money v4 and can't migrate to v6 on master, so should we probably just make a separate branch for v6 in your repo as well? What do you think?