2nd iteration on GTFS adaptation #961
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArnaudOggy
force-pushed
the
feature/2nd_iteration_on_pickup_drop_off_windows
branch
3 times, most recently
from
d52c4e0
to
09af95a
Compare
datanel
force-pushed
the
feature/2nd_iteration_on_pickup_drop_off_windows
branch
from
09af95a
to
315bbb8
Compare
datanel
approved these changes
Oct 7, 2024
src/gtfs/write.rs
Outdated
Comment on lines
483
to
489
| let booking_rule_id_opt = vj.booking_rule_links.first().and_then(|br_id| { | ||
| if st.pickup_type == 2u8 || st.drop_off_type == 2u8 { | ||
| Some(br_id.clone()) | ||
| } else { | ||
| None | ||
| } | ||
| }); |
There was a problem hiding this comment.
Suggested change
| let booking_rule_id_opt = vj.booking_rule_links.first().and_then(|br_id| { | |
| if st.pickup_type == 2u8 || st.drop_off_type == 2u8 { | |
| Some(br_id.clone()) | |
| } else { | |
| None | |
| } | |
| }); | |
| let booking_rule_id_opt = vj.booking_rule_links.first().filter(|_| { | |
| st.pickup_type == 2u8 || st.drop_off_type == 2u8 | |
| }).cloned(); | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref. https://navitia.atlassian.net/browse/NAV-3419 / https://navitia.atlassian.net/browse/NAV-3425