Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim leading and trailing whitespace from comment on read #145

Open
colindean opened this issue Mar 5, 2017 · 2 comments
Open

Trim leading and trailing whitespace from comment on read #145

colindean opened this issue Mar 5, 2017 · 2 comments

Comments

@colindean
Copy link
Contributor

So that the XML and any other representation doesn't have the whitespace.

@colindean
Copy link
Contributor Author

Looks like trimming at the point of creation could be appropriate. That's Parser.scala:22. It could also be in the definition of the comment extractor at line 43. This is my first time attempting to understand parser combinators, so I'm not quite sure what is right.

@hrj
Copy link
Owner

hrj commented Mar 6, 2017

Line 43 seems more appropriate, as it sits at a higher level. Line 22 does the tokenisation (lexical phase).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants