Add version and build of cppfront to generated files. #791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Signed-off-by: Herb Sutter <herb.sutter@gmail.com>
|
Thanks! I added a flag so that it's opt-in, because likely users won't want this to generate extra diffs just because they updated their compiler. I noticed that there seemed to be a large diff conflict, and unfortunately when I tried to resolve the conflict it seems to have lost the code change, and when I went back into the branch to restore it git wanted me to pull over 60 commits. I wonder if something got broken, and you should regenerate this PR? Sorry for the busywork, I appreciate the suggestion! |
|
I had to 'manually cherry pick' your commit. Sorry about that. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would find it useful to track which version of cppfront generated a .cpp or .h file.