Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error calculation on marginal statistics #28

Open
htjb opened this issue Jul 13, 2023 · 0 comments
Open

Better error calculation on marginal statistics #28

htjb opened this issue Jul 13, 2023 · 0 comments

Comments

@htjb
Copy link
Owner

htjb commented Jul 13, 2023

Currently, we input samples from the trained MAF or KDE to calculate the marginal statistics and samples from the original posterior then compare the results to get an error. I think the code needs a bit of a tidy, and it would be good to think about whether there is a better way to get an error on these statistics e.g. some monte carlo error.

I also think that the option to put in prior samples and prior weights to marginal_stats.calculate().statistics() should be scrapped in favour of supplying a prior density estimator so that the user can access all the fun stuff like early stopping and clustering.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant