Added smarthost support #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huan
requested changes
Nov 30, 2016
| @@ -18,6 +18,7 @@ Environment Variables: | |||
| SMF_DOMAIN - mail server hostname. use tutum/docker hostname if omitted. | |||
| SMF_CONFIG - mail forward addresses mapping list. | |||
| SMF_MYNETWORKS - configure relaying from trusted IPs, see http://www.postfix.org/postconf.5.html#mynetworks | |||
| SMF_SMARTHOST - configure a smarthost | |||
There was a problem hiding this comment.
I suggest we should use SMF_RELAYHOST as the variable name as we are modifying the relayhost parameter of postfix.
| @@ -171,6 +172,15 @@ function start_postfix { | |||
| echo "$HOSTNAME" > /etc/mailname | |||
| echo "$HOSTNAME" > /etc/hostname | |||
|
|
|||
| if [ "$SMF_SMARTHOST" = "" ]; then | |||
| SMF_SMARTHOST=$1 | |||
There was a problem hiding this comment.
I think it's not necessary to use $1 as the default value of SMF_RELAYHOST. Because it's not a so important setting for all users.
If there's no SMF_RELAYHOST set, we should just ignore it.
huan
requested changes
Nov 30, 2016
| @@ -18,6 +18,7 @@ Environment Variables: | |||
| SMF_DOMAIN - mail server hostname. use tutum/docker hostname if omitted. | |||
| SMF_CONFIG - mail forward addresses mapping list. | |||
| SMF_MYNETWORKS - configure relaying from trusted IPs, see http://www.postfix.org/postconf.5.html#mynetworks | |||
| SMF_RELAYHOST - configure a smarthost | |||
There was a problem hiding this comment.
smarthost should also rename to relayhost
|
I hope you agree with it now. If it's still not right, I'll leave it up to you to accept and adjust or deny completely. |
|
All looks good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smarthost support added; this wil solve issue #18