Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oauth requests don't unmarshal query string responses correctly #39

Closed
teepark opened this issue Jul 27, 2015 · 0 comments
Closed

oauth requests don't unmarshal query string responses correctly #39

teepark opened this issue Jul 27, 2015 · 0 comments
Labels

Comments

@teepark
Copy link

teepark commented Jul 27, 2015

Session.sendOauthRequest supports parsing a response with url.ParseQuery if it looks like urlencoded, but then Result.DecodeField expects the values to already be of the correct type, which won't be the case for anything but strings.

I ran into this with App.ExchangeToken, where the response includes an int "expires". It always ends up with a 0 for the expiration and the error field 'expires' value is string, not a number.

@huandu huandu added the bug label Jul 29, 2015
@huandu huandu closed this as completed in ff27e4b Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants