Skip to content

Fix spurious label column when directories match split names #7881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −0
Open

Fix spurious label column when directories match split names #7881

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/datasets/packaged_modules/folder_based_builder/folder_based_builder.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,12 @@ def analyze(files_or_archives, downloaded_files_or_dirs, split):
if self.config.drop_labels is None
else not self.config.drop_labels
)

if add_labels and labels:
common_split_names = {"train", "training", "test", "testing", "val", "valid", "validation", "dev", "eval"}
split_names = set(data_files.keys())
if labels.issubset(common_split_names | split_names):
add_labels = False

if add_labels:
logger.info("Adding the labels inferred from data directories to the dataset's features...")
Expand Down