Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add upload to s3 example #8

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Conversation

McPatate
Copy link
Member

Adding an example script to upload a file to s3

@McPatate McPatate requested a review from Narsil March 24, 2023 16:30
@McPatate McPatate force-pushed the feat/add_upload_to_s3_example branch from 4eb877c to 14ebe8d Compare March 24, 2023 16:32
Copy link
Collaborator

@Narsil Narsil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would personally leave it as a single file to keep thing compact, and especially since there's only shallow dependencies.

examples/upload_to_s3.py

#!pip install boto==1.26.98

within the file if you really want to keep them here.

@McPatate
Copy link
Member Author

McPatate commented Mar 24, 2023

True, I've added a comment with the pip install without the !

@McPatate McPatate merged commit 888dee0 into main Mar 24, 2023
@McPatate McPatate deleted the feat/add_upload_to_s3_example branch March 24, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants