Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(server): fix reshaping of bloom past_key_values in concatenate() #252

Merged
merged 1 commit into from
Apr 27, 2023
Merged

fix(server): fix reshaping of bloom past_key_values in concatenate() #252

merged 1 commit into from
Apr 27, 2023

Conversation

njhill
Copy link
Contributor

@njhill njhill commented Apr 27, 2023 •
edited
Loading

Introduced in #214

Fixes #249

OlivierDehaene
OlivierDehaene approved these changes Apr 27, 2023
View reviewed changes
Copy link
Member

@OlivierDehaene OlivierDehaene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@paulcx
Copy link

paulcx commented Apr 27, 2023

It works now!

@OlivierDehaene OlivierDehaene merged commit b4cf832 into huggingface:main Apr 27, 2023
@njhill njhill deleted the tgi/fix_past_shape branch April 27, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierDehaene OlivierDehaene OlivierDehaene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concurrent issue - batch size can not be greater than 1
3 participants
@njhill @paulcx @OlivierDehaene