Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Vision Transformer + ViTFeatureExtractor #10513
Add Vision Transformer + ViTFeatureExtractor #10513
Changes from 38 commits
ffa4bf8
a8d48c2
8363469
f4e4fb3
ff97a92
46ea2b6
b6fba1c
bc6f12d
56ccfa8
dc3c23f
d3607b4
dca36be
9f40352
6da3261
d48609a
43524d0
b168ee4
c39f155
20e3d1e
b2b3432
43ba11f
4fb8def
4c91fb3
c3dfbe6
5cd7dfd
9637b85
872ae16
a7a9e0e
466cef1
647f0e4
e01294c
0e02f64
02c06bc
f5ba2f4
852b777
03b7638
f6556b5
884b7a7
f35360e
f9a1ac6
472f96d
e790c1d
8b95a1e
37ae119
c6c0f27
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seeing this is looks like the ViT support is quite incomplete, even though it's not the case. I think we should eventually rethink how this is designed so that feature processors are highlighted here. Maybe by modifying "Tokenizer slow" to be "Pre-processor" and "Tokenizer fast" to be "Performance-optimized pre-processor". Let's think about it cc @sgugger
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is for a further PR though ;-) But yes, definitely worth a look!