FEAT / Trainer: Add adamw 4bit optimizer #31865
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
This PR adds the 4-bit optimizer from torchao library into HF Trainer. For now, it requires the main branch of
torchao
and torch >=2.3 (maybe we can wait a bit before merging). For those who wants to try, you can passoptim="adamw_torch_4bit"
inTrainingArguments
.Since we already have the 8-bit optimizer from bnb that works well, i'm not adding it.
Related thread : https://x.com/marksaroufim/status/1809398186198593566
cc @muellerzr as you might be interested