Skip to content

Conversation

@gante
Copy link
Member

@gante gante commented Oct 2, 2025

What does this PR do?

See title. These are causing our doc builder to crash.


how to locally test the doc builder:

  1. clone and install the doc builder
  2. run doc-builder build transformers docs/source/ja/ --language ja --clean (replace ja by the target language of your choice)

@gante gante requested a review from zucchini-nlp October 2, 2025 12:50
title: Entrenador
- local: sagemaker
title: Ejecutar el entrenamiento en Amazon SageMaker
- local: serialization
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in es, it, and pt: serialization.md was very outdated and doesn't match our recent practices -> delete

Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh god, we really need to organize non-English language docs. Forgot they existed 🙃

@gante gante enabled auto-merge (squash) October 2, 2025 12:57
@gante gante merged commit 248e7ef into huggingface:main Oct 2, 2025
16 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@ydshieh
Copy link
Collaborator

ydshieh commented Oct 2, 2025

Should we try to avoid the doc build workflow run failing because of a failure from the build for other language?

i.e. always upload the built en doc (if it builds successfully).

@gante
Copy link
Member Author

gante commented Oct 2, 2025

@ydshieh yeah that would be nice (since it's the most relevant language, and we always check its CI at merge time)

@gante gante deleted the ci_doc_builder branch October 2, 2025 14:02
@ydshieh
Copy link
Collaborator

ydshieh commented Oct 2, 2025

OK, will try to see if I can make that work

yuchenxie4645 pushed a commit to yuchenxie4645/transformers that referenced this pull request Oct 4, 2025
… (onnx, feature processors) (huggingface#41286)

remove references to old classes
AhnJoonSung pushed a commit to AhnJoonSung/transformers that referenced this pull request Oct 12, 2025
… (onnx, feature processors) (huggingface#41286)

remove references to old classes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants