Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests/test_tokenization_reformer.py #6485

Merged

Conversation

D-Roberts
Copy link
Contributor

As titled. Attends to issue #6333.

@codecov
Copy link

codecov bot commented Aug 14, 2020

Codecov Report

Merging #6485 into master will increase coverage by 0.58%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6485      +/-   ##
==========================================
+ Coverage   80.03%   80.61%   +0.58%     
==========================================
  Files         156      156              
  Lines       28058    28058              
==========================================
+ Hits        22456    22620     +164     
+ Misses       5602     5438     -164     
Impacted Files Coverage Δ
src/transformers/tokenization_albert.py 28.84% <0.00%> (-58.66%) ⬇️
src/transformers/modeling_tf_gpt2.py 71.84% <0.00%> (-23.17%) ⬇️
src/transformers/pipelines.py 79.69% <0.00%> (-0.26%) ⬇️
src/transformers/generation_tf_utils.py 86.46% <0.00%> (+0.25%) ⬆️
src/transformers/configuration_utils.py 96.59% <0.00%> (+0.68%) ⬆️
src/transformers/modeling_tf_utils.py 87.29% <0.00%> (+0.97%) ⬆️
src/transformers/modeling_openai.py 82.25% <0.00%> (+1.29%) ⬆️
src/transformers/tokenization_auto.py 97.77% <0.00%> (+2.22%) ⬆️
src/transformers/tokenization_reformer.py 95.00% <0.00%> (+13.33%) ⬆️
src/transformers/tokenization_mbart.py 95.31% <0.00%> (+39.06%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ba758...66f97dd. Read the comment docs.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks! Pinging @patrickvonplaten

Copy link
Contributor

@patrickvonplaten patrickvonplaten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot @D-Roberts !

@patrickvonplaten patrickvonplaten merged commit c945450 into huggingface:master Aug 20, 2020
Zigur pushed a commit to Zigur/transformers that referenced this pull request Oct 26, 2020
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
@D-Roberts D-Roberts deleted the test_tokenization_reformer branch December 21, 2020 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants