Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move threshold up for flaky test with Electra #6622

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Move threshold up for flaky test with Electra #6622

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ec31963
Move threshold up for flaky test with Electra
sgugger Aug 20, 2020
ef1053f
Update above as well
sgugger Aug 20, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/test_modeling_tf_common.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,13 +306,13 @@ def test_pt_tf_model_equivalence(self):

max_diff = np.amax(np.abs(tf_hidden_states - pt_hidden_states))
# Debug info (remove when fixed)
if max_diff >= 2e-2:
if max_diff >= 4e-2:
print("===")
print(model_class)
print(config)
print(inputs_dict)
print(pt_inputs_dict)
self.assertLessEqual(max_diff, 2e-2)
self.assertLessEqual(max_diff, 4e-2)
Copy link
Contributor

@patrickvonplaten patrickvonplaten Aug 20, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

think we should update the if max_diff >= 2e-2: to 4-e2 as well.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see it, thanks for catching that mistake!


# Check we can load pt model in tf and vice-versa with checkpoint => model functions
with tempfile.TemporaryDirectory() as tmpdirname:
Expand Down