Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move unused args to kwargs #6694

Merged
merged 1 commit into from
Aug 24, 2020
Merged

Move unused args to kwargs #6694

merged 1 commit into from
Aug 24, 2020

Conversation

sgugger
Copy link
Collaborator

@sgugger sgugger commented Aug 24, 2020

Those arguments are poped from the kwargs since specific to optuna for now.

@sgugger sgugger requested a review from LysandreJik August 24, 2020 17:13
@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #6694 into master will decrease coverage by 0.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6694      +/-   ##
==========================================
- Coverage   79.68%   78.95%   -0.74%     
==========================================
  Files         156      156              
  Lines       28386    28386              
==========================================
- Hits        22619    22411     -208     
- Misses       5767     5975     +208     
Impacted Files Coverage Δ
src/transformers/trainer.py 13.17% <ø> (-37.57%) ⬇️
src/transformers/training_args.py 66.66% <0.00%> (-25.00%) ⬇️
src/transformers/trainer_utils.py 64.44% <0.00%> (-20.00%) ⬇️
src/transformers/tokenization_ctrl.py 78.64% <0.00%> (-17.48%) ⬇️
src/transformers/tokenization_dpr.py 53.15% <0.00%> (-4.51%) ⬇️
src/transformers/data/datasets/glue.py 83.58% <0.00%> (-2.99%) ⬇️
src/transformers/file_utils.py 82.41% <0.00%> (+0.25%) ⬆️
src/transformers/tokenization_utils.py 90.40% <0.00%> (+0.40%) ⬆️
src/transformers/tokenization_bert.py 91.51% <0.00%> (+0.44%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 912a21e...cd84cb9. Read the comment docs.

@sgugger sgugger merged commit 6b4c617 into master Aug 24, 2020
@sgugger sgugger deleted the too_many_args branch August 24, 2020 17:20
Zigur pushed a commit to Zigur/transformers that referenced this pull request Oct 26, 2020
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant