ci/gh/self-scheduled: add newline to make examples tests run even if src/ tests fail #6706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6706 +/- ##
==========================================
+ Coverage 78.80% 79.44% +0.64%
==========================================
Files 156 156
Lines 28386 28386
==========================================
+ Hits 22369 22552 +183
+ Misses 6017 5834 -183
Continue to review full report at Codecov.
|
LysandreJik
reviewed
Aug 25, 2020
| @@ -58,6 +58,7 @@ jobs: | |||
| run: | | |||
| source .env/bin/activate | |||
| python -m pytest -n 1 --dist=loadfile -s ./tests/ | |||
|
|
|||
There was a problem hiding this comment.
I don't think this will change anything though?
|
I'm pretty sure that the tests stop as soon as there's a failure in one of the items. It would seem logical since there could be a relationship between tests, e.g., a test needing the output of the previous test to continue. Still merging because it looks more consistent this way! |
Zigur
pushed a commit
to Zigur/transformers
that referenced
this pull request
Oct 26, 2020
fabiocapsouza
pushed a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
fabiocapsouza
added a commit
to fabiocapsouza/transformers
that referenced
this pull request
Nov 15, 2020
This reverts commit 7114344.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment, the examples tests dont run if the src/ tests don't
this is not the case for self-push I don't think. I don't know why.
Maybe you have an idea @julien-c ?
https://github.com/huggingface/transformers/runs/1024137280?check_suite_focus=true
Gunna merge this tomorrow cause it can't hurt, then try harder/stackoverflow if it doesn't work.