Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Albert] Add position ids to allowed uninitialized weights #6719

Merged
merged 1 commit into from
Aug 25, 2020
Merged

[Albert] Add position ids to allowed uninitialized weights #6719

merged 1 commit into from
Aug 25, 2020

Conversation

patrickvonplaten
Copy link
Contributor

Fixes #6700

@patrickvonplaten patrickvonplaten linked an issue Aug 25, 2020 that may be closed by this pull request
Some weights of AlbertModel were not initialized ['albert.embeddings.position_ids'] #6700
Closed
@codecov
Copy link

codecov bot commented Aug 25, 2020

Codecov Report

Merging #6719 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6719      +/-   ##
==========================================
- Coverage   79.49%   79.48%   -0.01%     
==========================================
  Files         156      156              
  Lines       28405    28406       +1     
==========================================
- Hits        22581    22579       -2     
- Misses       5824     5827       +3
Impacted Files Coverage Δ
src/transformers/modeling_albert.py 83.53% <100.00%> (+0.03%) ⬆️
src/transformers/generation_tf_utils.py 85.71% <0.00%> (-0.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 625318f...8f67175. Read the comment docs.

LysandreJik
LysandreJik approved these changes Aug 25, 2020
View reviewed changes
Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@LysandreJik LysandreJik merged commit d17cce2 into huggingface:master Aug 25, 2020
Zigur pushed a commit to Zigur/transformers that referenced this pull request Oct 26, 2020
@patrickvonplaten @Zigur
add missing keys (huggingface#6719)
15c75f8
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
@patrickvonplaten @fabiocapsouza
add missing keys (huggingface#6719)
efc4420
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
@fabiocapsouza
Revert "add missing keys (huggingface#6719)"
7e3acc6 
This reverts commit efc4420.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LysandreJik LysandreJik LysandreJik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Some weights of AlbertModel were not initialized ['albert.embeddings.position_ids']
2 participants
@patrickvonplaten @LysandreJik