Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix run_squad.py to work with BART #6756

Merged
merged 1 commit into from
Aug 27, 2020

Conversation

tomgrek
Copy link
Contributor

@tomgrek tomgrek commented Aug 26, 2020

BART model should be among the set that doesn't use token_type_ids.

@codecov
Copy link

codecov bot commented Aug 26, 2020

Codecov Report

Merging #6756 into master will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6756      +/-   ##
==========================================
+ Coverage   79.65%   79.82%   +0.16%     
==========================================
  Files         157      157              
  Lines       28479    28479              
==========================================
+ Hits        22686    22734      +48     
+ Misses       5793     5745      -48     
Impacted Files Coverage Δ
src/transformers/modeling_tf_xlm.py 18.94% <0.00%> (-74.32%) ⬇️
src/transformers/modeling_roberta.py 77.37% <0.00%> (-19.71%) ⬇️
src/transformers/file_utils.py 82.66% <0.00%> (+0.25%) ⬆️
src/transformers/tokenization_utils.py 89.84% <0.00%> (+0.39%) ⬆️
src/transformers/tokenization_bert.py 91.51% <0.00%> (+0.44%) ⬆️
src/transformers/tokenization_utils_fast.py 94.28% <0.00%> (+1.42%) ⬆️
src/transformers/tokenization_openai.py 84.09% <0.00%> (+1.51%) ⬆️
src/transformers/generation_tf_utils.py 86.46% <0.00%> (+3.00%) ⬆️
src/transformers/tokenization_transfo_xl.py 42.48% <0.00%> (+3.75%) ⬆️
src/transformers/tokenization_utils_base.py 93.76% <0.00%> (+7.18%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61b9ed8...7ba95ec. Read the comment docs.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks!

@LysandreJik LysandreJik merged commit c225e87 into huggingface:master Aug 27, 2020
Zigur pushed a commit to Zigur/transformers that referenced this pull request Oct 26, 2020
fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants