Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create model card for pre-trained NLI models. #7864

Merged
merged 3 commits into from
Oct 24, 2020

Conversation

easonnie
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dimiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to the it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors which may be interested in your PR.

@julien-c julien-c added the model card Related to pretrained model cards label Oct 17, 2020
Copy link
Member

@julien-c julien-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thanks for sharing!

Could you add metadata links to the datasets that were used, using huggingface/datasets identifiers (listed in https://huggingface.co/datasets)? This will help tremendously for discoverability.

If a dataset isn't in datasets yet, you can still add it in the metadat (this will prompt us – or a community member – to add it)

cc @lhoestq and @thomwolf on the datasets side, @mapmeld on the metadata side, and @joeddav for his interest on NLI models

@easonnie
Copy link
Contributor Author

Hi @julien-c, thank you so much for the pointer. I have added the dataset identifier and license.

@julien-c julien-c merged commit 00602f7 into huggingface:master Oct 24, 2020
@julien-c
Copy link
Member

julien-c commented Oct 24, 2020

Thanks! Your model is now linked from https://huggingface.co/datasets/anli (and the other datasets)

fabiocapsouza pushed a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
* Create README.md

* Update model_cards/ynie/roberta-large-snli_mnli_fever_anli_R1_R2_R3-nli/README.md

Co-authored-by: Julien Chaumond <chaumond@gmail.com>

* Add Meta information for dataset identifier.

Co-authored-by: Julien Chaumond <chaumond@gmail.com>
fabiocapsouza added a commit to fabiocapsouza/transformers that referenced this pull request Nov 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
model card Related to pretrained model cards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants