-
Notifications
You must be signed in to change notification settings - Fork 2.3k
⌨️ Pin num2words #4094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⌨️ Pin num2words #4094
Conversation
Pin `num2words` to avoid supply chain attack: https://www.stepsecurity.io/blog/supply-chain-security-alert-num2words-pypi-package-shows-signs-of-compromise
albertvillanova
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the security fix!!!
However, I must admit I'm not sure about how to proceed in this case:
- The 0.5.15 version was already remove from PyPI (but may still live in mirrors or caches)
- Pinning to 0.5.14 has 2 potential drawbacks
- User that need a lower version (due to other local constraints)
- No further legitimate bug fixes are allowed
Any other opininons?
|
I've expanded the pin to the example scripts. No strong opinions about what @albertvillanova shares. We could possibly pin this version now and review it again in a while. |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Thanks! I'd be in favour of pinning for now and then we relax at some future date. But no strong opinion either way :) |
qgallouedec
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No strong opinion either 😅
What does this PR do?
Pin
num2wordsto avoid supply chain attack: https://www.stepsecurity.io/blog/supply-chain-security-alert-num2words-pypi-package-shows-signs-of-compromiseBefore submitting
Pull Request section?
to it if that's the case.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.