Skip to content

Conversation

@behroozazarkhalili
Copy link
Collaborator

Resolves #4397

Summary

This PR moves the Multi-Adapter RL content from a standalone documentation page to the PEFT integration guide, where it fits better contextually.

Changes

  • Moved content: Relocated Multi-Adapter RL section to peft_integration.md as a subsection
  • Removed file: Deleted docs/source/multi_adapter_rl.md
  • Updated navigation: Removed Multi Adapter RLHF reference from _toctree.yml
  • Preserved information: All technical details, examples, and warnings maintained

Rationale

The Multi-Adapter RL functionality is specifically about using PEFT with PPO for RL training. As an advanced PEFT usage pattern, it makes more sense to document it within the PEFT integration guide rather than as a standalone section.

The content now appears as a subsection titled "Multi-Adapter RL Training" within the PEFT integration guide, positioned before the "Naive pipeline parallelism" section.

Resolves #4386

- Add "Supported Trainers" section listing SFT, DPO, GRPO, KTO, and GKD
- Replace single SFT example with hfoptions showing all 5 supported trainers
- Remove "under construction" warning as guide is now complete
- Follow same format as reducing_memory_usage.md for consistency
Resolves #4397

- Moved Multi-Adapter RL content from standalone page to PEFT integration guide
- Removed docs/source/multi_adapter_rl.md file
- Updated _toctree.yml to remove Multi Adapter RLHF reference
- Reorganized content as subsection within PEFT integration
- Kept experimental warnings and technical details intact
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@behroozazarkhalili
Copy link
Collaborator Author

@qgallouedec The liger_kernel_integration.md file is not actually modified in this PR.

The confusion comes from the branch history - I had previously worked on the Liger Kernel docs (which was merged as #4432), and when I created this branch, it included that commit in the history. However, the actual file changes in this PR only affect:

  1. docs/source/_toctree.yml (-2 lines)
  2. docs/source/multi_adapter_rl.md (deleted, -102 lines)
  3. docs/source/peft_integration.md (+88 lines)

You can verify this by checking the "Files changed" tab - liger_kernel_integration.md doesn't appear there.

Ready for review!

@qgallouedec qgallouedec merged commit 1cb0161 into main Nov 4, 2025
3 checks passed
@qgallouedec qgallouedec deleted the docs/move-multi-adapter-rl branch November 4, 2025 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove or move Multi Adapter RL

4 participants