Resolve undefined names in retdec.py #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[NameError](https://docs.python.org/3/library/exceptions.html#NameError) discovered in hugsy/gef#251 (comment) _Partial_ fix to hugsy#4
Grazfather
reviewed
Apr 9, 2018
|
|
||
| import gdb | ||
|
|
||
| from gef import (GEF_TEMP_DIR, PYTHON_MAJOR, current_arch, err, get_arch, |
There was a problem hiding this comment.
Why not just hcange the script to use gef.<name>?
There was a problem hiding this comment.
Fewer lines changed, more flexibility when refactoring, shorter lines that are easier to read and faster runtime (avoid the dots).
7 tasks
cclauss
pushed a commit
to cclauss/gef
that referenced
this pull request
Apr 14, 2018
Now that hugsy/gef-extras#5 is fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NameError discovered in hugsy/gef#251 (comment)
Partial fix to #4