From 87d492b268acc7ae3c0d9f24ab2d5b034d710336 Mon Sep 17 00:00:00 2001 From: Mike Selander Date: Tue, 18 Dec 2018 11:45:26 -0700 Subject: [PATCH] Remove href-no-hash rule, as config-react-app has been updated --- packages/eslint-config-humanmade/index.js | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/packages/eslint-config-humanmade/index.js b/packages/eslint-config-humanmade/index.js index eb94a005..0892d920 100644 --- a/packages/eslint-config-humanmade/index.js +++ b/packages/eslint-config-humanmade/index.js @@ -9,7 +9,7 @@ module.exports = { 'react-app', ], 'parserOptions': { - 'ecmaVersion': 2018, + 'ecmaVersion': 2018, 'ecmaFeatures': { 'jsx': true, }, @@ -97,9 +97,5 @@ module.exports = { 'react/jsx-curly-spacing': [ 'error', 'always' ], 'react/jsx-wrap-multilines': [ 'error' ], 'jsx-a11y/anchor-is-valid': [ 'error' ], - // href-no-hash has been removed from jsx-a11y: this line silences an error - // caused by eslint-config-react-app still using the deprecated rule, and - // can be removed once the react-app config is updated to a recent jsx-a11y. - 'jsx-a11y/href-no-hash': [ 'off' ], }, };