Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly address sp_tracing and log usage #1327

Open
dmitrylavrenov opened this issue Nov 7, 2024 · 0 comments
Open

Properly address sp_tracing and log usage #1327

dmitrylavrenov opened this issue Nov 7, 2024 · 0 comments

Comments

@dmitrylavrenov
Copy link
Contributor

dmitrylavrenov commented Nov 7, 2024

As a follow up of #1325 - when would we need to use tracing (and when not - and use just log)

Please, check the details here - #1325 (comment)
Also, see #1326

Reading up on the comments in that PR - it seems like tracing is not used for logging in the general purpose, but for something else that is kind of very specific and that I didn't anticipate they'd design like that. In particular - there is a specific feature for block re-execution with tracing. Who would want that and why is a mystery to me as of now - but at least it is now clear there is a distinction in the purpose of the regular logging infrastructure and sp_tracing logging. It is clear that the difference is beyond them just being two logging frontends - as they seem to be targeting different backends - so we have to learn and figure out when to use which.

To be more explicit here - I clearly was wrong about always using tracing. I think that, by default, we'd actually want to use frame_support::log APIs.

We also must figure out what they use tracing for.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant