From 8ceef0e5e5e9bfbd61fc88c607e955b1a8ac8e22 Mon Sep 17 00:00:00 2001 From: Yuriy Bakhtin Date: Wed, 25 Oct 2023 18:51:53 +0200 Subject: [PATCH] Fix visibility of the method `Controller::getAccessRules()` --- controllers/ChecklistController.php | 7 +++++-- controllers/ConfigController.php | 2 +- controllers/GlobalController.php | 7 +++++-- controllers/ListController.php | 5 ++++- controllers/SearchController.php | 6 ++++-- controllers/TaskController.php | 5 ++++- docs/CHANGELOG.md | 1 + 7 files changed, 24 insertions(+), 9 deletions(-) diff --git a/controllers/ChecklistController.php b/controllers/ChecklistController.php index 2a20c25a..ee9799e4 100644 --- a/controllers/ChecklistController.php +++ b/controllers/ChecklistController.php @@ -13,7 +13,10 @@ class ChecklistController extends AbstractTaskController { - public function getAccessRules() + /** + * @inheritdoc + */ + protected function getAccessRules() { return [ [ContentContainerControllerAccess::RULE_USER_GROUP_ONLY => [Space::USERGROUP_MEMBER, User::USERGROUP_SELF]] @@ -36,4 +39,4 @@ public function actionCheckItem($id, $taskId) return $this->asJson(['success' => false, 'message' => ($model->hasErrors()) ? $model->getFirstErrors() : '']); } -} \ No newline at end of file +} diff --git a/controllers/ConfigController.php b/controllers/ConfigController.php index 174193bb..79cfe114 100644 --- a/controllers/ConfigController.php +++ b/controllers/ConfigController.php @@ -25,7 +25,7 @@ class ConfigController extends Controller /** * @inheritdoc */ - public function getAccessRules() + protected function getAccessRules() { return [['permissions' => ManageModules::class]]; } diff --git a/controllers/GlobalController.php b/controllers/GlobalController.php index 42bff3dd..f4c2b9c3 100644 --- a/controllers/GlobalController.php +++ b/controllers/GlobalController.php @@ -19,7 +19,10 @@ class GlobalController extends AbstractTaskController { public $requireContainer = false; - public function getAccessRules() + /** + * @inheritdoc + */ + protected function getAccessRules() { return [ [ControllerAccess::RULE_LOGGED_IN_ONLY] @@ -44,4 +47,4 @@ public function actionFilter() ]); } -} \ No newline at end of file +} diff --git a/controllers/ListController.php b/controllers/ListController.php index 32865dea..52f7e4ac 100644 --- a/controllers/ListController.php +++ b/controllers/ListController.php @@ -30,7 +30,10 @@ class ListController extends AbstractTaskController { - public function getAccessRules() + /** + * @inheritdoc + */ + protected function getAccessRules() { return [ [ContentContainerControllerAccess::RULE_USER_GROUP_ONLY => [Space::USERGROUP_MEMBER, User::USERGROUP_SELF]], diff --git a/controllers/SearchController.php b/controllers/SearchController.php index 5e16a9ee..2f4b33df 100644 --- a/controllers/SearchController.php +++ b/controllers/SearchController.php @@ -25,7 +25,10 @@ class SearchController extends AbstractTaskController { - public function getAccessRules() + /** + * @inheritdoc + */ + protected function getAccessRules() { return [ [ContentContainerControllerAccess::RULE_USER_GROUP_ONLY => [Space::USERGROUP_MEMBER, User::USERGROUP_SELF]] @@ -67,4 +70,3 @@ public function actionJson() } } - diff --git a/controllers/TaskController.php b/controllers/TaskController.php index a71262f2..5a75f3b5 100644 --- a/controllers/TaskController.php +++ b/controllers/TaskController.php @@ -21,7 +21,10 @@ class TaskController extends AbstractTaskController public $hideSidebar = true; - public function getAccessRules() + /** + * @inheritdoc + */ + protected function getAccessRules() { return [ [ContentContainerControllerAccess::RULE_USER_GROUP_ONLY => [Space::USERGROUP_MEMBER, User::USERGROUP_SELF]], diff --git a/docs/CHANGELOG.md b/docs/CHANGELOG.md index e3055eba..9d54b96b 100644 --- a/docs/CHANGELOG.md +++ b/docs/CHANGELOG.md @@ -7,6 +7,7 @@ Changelog - Fix #234: Fix using of Yii on view files - Fix #236: Fix pagination design - Enh #238: Tests for `next` version +- Fix #242: Fix visibility of the method `Controller::getAccessRules()` 1.8.1 (May 1, 2023) -------------------