Skip to content

Commit

Permalink
Skip plugin for non-Flow JS code (facebook#1556)
Browse files Browse the repository at this point in the history
Summary:

This is a mitigation for facebook#1549.

Updates `babel-plugin-syntax-hermes-parser` to abort when the file contents do not include `flow`.

**Context: React Native**

Originally changed in facebook/react-native#46696, as our internal Flow support had diverged from `babel/plugin-syntax-flow` (facebook/react-native#46601).

We effectively have three flavours of JavaScript in support:
- Flow@latest for the `react-native` package, shipped as source — uses `hermes-parser`.
- TypeScript for product code (community template, Expo) — uses `babel/plugin-syntax-typescript`.
- Plain JavaScript/JSX in product code, *which may be extended with additional user Babel plugins and needs lenient parsing* — uses base `babel/parser` (**this change**).

I'd love to simplify this 😅.

Differential Revision: D65272155
  • Loading branch information
huntie authored and facebook-github-bot committed Nov 1, 2024
1 parent e3aec0f commit 4c10248
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import {transformSync} from '@babel/core';
import hermesParserPlugin from '../src';
import * as HermesParser from 'hermes-parser';

const MODULE_PREAMBLE = '"use strict";\n\n';
const MODULE_PREAMBLE = '// @flow\n\n"use strict";\n\n';

describe('babel-plugin-syntax-hermes-parser', () => {
test('test basic parsing', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,19 @@ export default function BabelPluginSyntaxHermesParser(
) {
return;
}

const opts: ParserOptions = {};
for (const [key, value] of Object.entries(curParserOpts)) {
if (HermesParser.ParserOptionsKeys.has(key)) {
// $FlowExpectedError[incompatible-type]
opts[key] = value;
}
}

if (opts.flow !== 'all' && !/@flow/.test(code)) {
return;
}

return HermesParser.parse(code, {...opts, babel: true});
},

Expand Down

0 comments on commit 4c10248

Please sign in to comment.