diff --git a/.changeset/late-spiders-fold.md b/.changeset/late-spiders-fold.md new file mode 100644 index 0000000..7bc1dc4 --- /dev/null +++ b/.changeset/late-spiders-fold.md @@ -0,0 +1,5 @@ +--- +"@graphcms/rich-text-react-renderer": patch +--- + +fix(react): simple elements are not empty diff --git a/packages/react-renderer/src/util/elementIsEmpty.ts b/packages/react-renderer/src/util/elementIsEmpty.ts index 574b1c4..8625dbe 100644 --- a/packages/react-renderer/src/util/elementIsEmpty.ts +++ b/packages/react-renderer/src/util/elementIsEmpty.ts @@ -28,5 +28,5 @@ export function elementIsEmpty({ return hasText.length > 0 ? false : true; } else if (children[0].text === '') return true; - return true; + return false; } diff --git a/packages/react-renderer/test/RichText.test.tsx b/packages/react-renderer/test/RichText.test.tsx index 934c153..02d4a34 100644 --- a/packages/react-renderer/test/RichText.test.tsx +++ b/packages/react-renderer/test/RichText.test.tsx @@ -12,6 +12,7 @@ import { inlineContent, emptyContent, embedAssetContent, + simpleH1Content, } from './content'; describe('@graphcms/rich-text-react-renderer', () => { @@ -99,6 +100,18 @@ describe('@graphcms/rich-text-react-renderer', () => { `); }); + it('should should render H1 with some text', () => { + const { container } = render(); + + expect(container).toMatchInlineSnapshot(` +
+

+ heading +

+
+ `); + }); + it('renders content with custom elements', () => { const { container } = render(