refactor(header): make some headers more allocator friendly #1119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanmonstar
reviewed
Apr 8, 2017
src/header/common/mod.rs
Outdated
| } | ||
| } | ||
| impl ::std::ops::Deref for $id { | ||
| type Target = ::std::borrow::Cow<'static,$value>; |
There was a problem hiding this comment.
So that we don't leak that it is actually a Cow inside, let's just Deref to the $value type instead. This will let us change Cow to a Bytes or something later, and it should all still just work.
Change the internal implementation of some simple headers to make them more allocator friendly. Also add a constructor method to allow changing the implementation in the future again. The headers are: - Location - Referrer - Server - UserAgent This change was suggested in [hyperium#1104]. BREAKING CHANGES: - Old code that creates the header structs directly will stop working. - It's not possible to implement DerefMut for a Cow<'static,str>. Code that needs to modify header after creation will stop working.
hannesg
force-pushed
the
allocator_friendly_header
branch
from
f25db1c to
c8d5bf5
Compare
|
@seanmonstar sure! I've updated that. |
|
Fantastic, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the internal implementation of some simple headers to make them
more allocator friendly. Also add a constructor method to allow changing
the implementation in the future again.
The headers are:
This change was suggested in #1104.
I've left out the Origin header for now because the internal implementation is different.
BREAKING CHANGES:
that needs to modify header after creation will stop working.