Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix integer overflow in ANTLR parser for 32 bit #134

Merged
merged 2 commits into from
Nov 5, 2020
Merged

Fix integer overflow in ANTLR parser for 32 bit #134

merged 2 commits into from
Nov 5, 2020

Conversation

niallnsec
Copy link
Collaborator

Fixes #133 as per suggestion in antlr/antlr4#2433

newm4n
newm4n approved these changes Nov 4, 2020
View reviewed changes
Copy link
Member

@newm4n newm4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its an ANTLR4 generated file.
This is only work around just to enable compilation on ARM works.
ANTLR4 team need to fix this, otherwise we need to do this everytime we regenerate the file.

@newm4n newm4n merged commit 3b593bf into hyperjumptech:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@newm4n newm4n newm4n approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Integer overflow when building for ARM7
2 participants
@niallnsec @newm4n