docs(examples): increase supply chain image boot responsiveness #780 #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ledger-cacti#780 Added logging to all 3 of the test ledger classes that are being used which are taking up most of the boot time. Now users can see the setup process as it chugs along step by step and in general be much more confident while waiting that things are indeed happening instead of the container just being in a zombie state. Also added an additional point in the README.md file claryfying that one needs to have a working installation of docker on their machine. Decided to not go into any more detail than that because the (linked) docker for desktop documentation is the best/most robust resrouces available there is and it would be hard to compete with it if we were to produce our own installation instructions. Fixes hyperledger-cacti#780 Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
added
documentation
Codecov Report
@@ Coverage Diff @@
## main #1152 +/- ##
==========================================
+ Coverage 73.18% 73.20% +0.02%
==========================================
Files 248 248
Lines 8744 8768 +24
Branches 1018 1023 +5
==========================================
+ Hits 6399 6419 +20
Misses 1796 1796
- Partials 549 553 +4
Continue to review full report at Codecov.
|
takeutak
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added logging to all 3 of the test ledger classes that are being used
which are taking up most of the boot time.
Now users can see the setup process as it chugs along step by step and
in general be much more confident while waiting that things are indeed
happening instead of the container just being in a zombie state.
Also added an additional point in the README.md file claryfying that
one needs to have a working installation of docker on their machine.
Decided to not go into any more detail than that because the (linked)
docker for desktop documentation is the best/most robust resrouces
available there is and it would be hard to compete with it if we were
to produce our own installation instructions.
Fixes #780
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com