Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] : Make Iroha version 2.0.0-pre-rc.19compatible for Blockchain Explorer #3880

Closed
horizenight opened this issue Sep 10, 2023 · 2 comments
Closed

[refactor] : Make Iroha version 2.0.0-pre-rc.19compatible for Blockchain Explorer #3880

horizenight opened this issue Sep 10, 2023 · 2 comments
Labels
api-changes Changes in the API for client libraries iroha2-dev The re-implementation of a BFT hyperledger in RUST

Comments

@horizenight
Copy link

Description

Currently, the blockchain explorer backend requires various methods that were in Iroha version 2.0.0-pre-rc.16 but are not present / structured changed in Iroha version 2.0.0-pre-rc.19.
This patch will be addressing commits related to it.
@horizenight horizenight self-assigned this Sep 10, 2023
horizenight pushed a commit to horizenight/iroha that referenced this issue Sep 11, 2023
[Patch] hyperledger-iroha#3880 : Make prepare_query_request public
55b9ef2 
Signed-off-by: Kshitij Roodkee <kshitijroodkee@Kshitijs-MacBook-Air.local>
@horizenight horizenight mentioned this issue Sep 11, 2023
Closed
5 tasks
@horizenight horizenight changed the title [Patch] : Make Iroha version 2.0.0-pre-rc.19compatible for Blockchain Explorer [patch] : Make Iroha version 2.0.0-pre-rc.19compatible for Blockchain Explorer Sep 11, 2023
horizenight pushed a commit to horizenight/iroha that referenced this issue Sep 11, 2023
@horizenight
[fix] hyperledger-iroha#3880 : Make prepare_query_request public
405846f 
Signed-off-by: Kshitij Roodkee <kshitijroodkee@Kshitijs-MacBook-Air.local>
@0x009922 0x009922 self-assigned this Sep 13, 2023
@0x009922
Copy link
Contributor

I researched code more in-depth. There are big changes after the merge of #3621. It almost reverts the work I made back then in #2146 & #2147. Now iroha_client crate doesn't provide transport-agnostic functionality anymore.

Thus, the major point of this fix is to make it transport-agnostic again. Will try to solve it shortly.

@0x009922 0x009922 added iroha2-dev The re-implementation of a BFT hyperledger in RUST api-changes Changes in the API for client libraries labels Sep 13, 2023
@horizenight horizenight changed the title [patch] : Make Iroha version 2.0.0-pre-rc.19compatible for Blockchain Explorer [refactor] : Make Iroha version 2.0.0-pre-rc.19compatible for Blockchain Explorer Sep 18, 2023
@nxsaken nxsaken added this to Iroha Sep 4, 2024
@nxsaken nxsaken moved this to Backlog in Iroha Sep 4, 2024
@0x009922
Copy link
Contributor

0x009922 commented Oct 4, 2024

Closing in favor of soramitsu/iroha2-block-explorer-backend#44

@0x009922 0x009922 closed this as completed Oct 4, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Iroha Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-changes Changes in the API for client libraries iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nxsaken @0x009922 @horizenight