-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor]: update iroha_telemetry_derive to use syn2 #4168
[refactor]: update iroha_telemetry_derive to use syn2 #4168
Conversation
Need to update failure tests as well if we proceed with these errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good (aside from minor nitpicks)!
Though would like to look at the changed error messages (if any)
The errors contain additional lines as emitter does not abrupt macro compilation like
What do you think about printing additional errors? |
This... doesn't seem right. Seems like the missing wsv argument is getting double-reported. I guess you don't need this check, as it's also checked later: https://github.com/hyperledger/iroha/pull/4168/files#diff-6fe38d7a884371cd14b17c23142ac64383dee34a81b9f87a5b81e3eeebc25ff7R162-R168 |
Adjusted |
Signed-off-by: VAmuzing <amuzik95@gmail.com>
Signed-off-by: VAmuzing <amuzik95@gmail.com>
Signed-off-by: VAmuzing <amuzik95@gmail.com>
…oha#4168) Signed-off-by: VAmuzing <amuzik95@gmail.com> Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
…oha#4168) Signed-off-by: VAmuzing <amuzik95@gmail.com>
Description
Update with refactoring to remove proc_macro_error in favour of our
Emitter
wrapperLinked issue
Closes #3909
Checklist
CONTRIBUTING.md