-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[refactor]: Fix CI lints after bump of toolchain version #4201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mversic
requested review from
s8sato,
Arjentix,
SamHSmith,
QuentinI,
outoftardis,
ilchu,
pesterev,
Erigara,
0x009922 and
DCNick3
as code owners
January 15, 2024 09:03
github-actions
bot
added
the
iroha2-dev
The re-implementation of a BFT hyperledger in RUST
label
Jan 15, 2024
mversic
force-pushed
the
fix_lints
branch
3 times, most recently
from
January 15, 2024 09:08
ba8684d
to
5b9721c
Compare
DCNick3
reviewed
Jan 15, 2024
DCNick3
reviewed
Jan 15, 2024
DCNick3
previously approved these changes
Jan 15, 2024
mversic
force-pushed
the
fix_lints
branch
4 times, most recently
from
January 15, 2024 09:28
c69cb5a
to
c5f5de2
Compare
Pull Request Test Coverage Report for Build 7527153546
💛 - Coveralls |
Arjentix
previously approved these changes
Jan 15, 2024
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Arjentix
approved these changes
Jan 15, 2024
DCNick3
approved these changes
Jan 15, 2024
mversic
added a commit
to mversic/iroha
that referenced
this pull request
Jan 18, 2024
…-iroha#4201) Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Asem-Abdelhady
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this pull request
Jan 18, 2024
…-iroha#4201) Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Asem-Abdelhady
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this pull request
Jan 18, 2024
…-iroha#4201) Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Asem-Abdelhady
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this pull request
Jan 18, 2024
…-iroha#4201) Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Asem-Abdelhady
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this pull request
Jan 22, 2024
…-iroha#4201) Signed-off-by: Marin Veršić <marin.versic101@gmail.com> Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Asem-Abdelhady
pushed a commit
to Asem-Abdelhady/iroha
that referenced
this pull request
Feb 9, 2024
…-iroha#4201) Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed CI lints
missing_panics_doc
now fires for every public function that callsOption::expect
orResult::expect
. In some cases (likeMetadata
) I've extracted the panicking into a special private function because I don't think it's a good solution to just slapmissing_panics_doc
on every function that asserts invariants. We definitely want to get rid of these warnings, but what to do about it?Linked issue
Closes #{issue_number}
Benefits
Checklist
CONTRIBUTING.md