Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: Fix CI lints after bump of toolchain version #4201

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

mversic
Copy link
Contributor

@mversic mversic commented Jan 15, 2024

Description

Fixed CI lints

missing_panics_doc now fires for every public function that calls Option::expect or Result::expect. In some cases (like Metadata) I've extracted the panicking into a special private function because I don't think it's a good solution to just slap missing_panics_doc on every function that asserts invariants. We definitely want to get rid of these warnings, but what to do about it?

Linked issue

Closes #{issue_number}

Benefits

Checklist

  • I've read CONTRIBUTING.md
  • I've used the standard signed-off commit format (or will squash just before merging)
  • All applicable CI checks pass (or I promised to make them pass later)
  • (optional) I've written unit tests for the code changes
  • I replied to all comments after code review, marking all implemented changes with thumbs up

@github-actions github-actions bot added the iroha2-dev The re-implementation of a BFT hyperledger in RUST label Jan 15, 2024
@mversic mversic force-pushed the fix_lints branch 3 times, most recently from ba8684d to 5b9721c Compare January 15, 2024 09:08
crypto/src/hash.rs Outdated Show resolved Hide resolved
DCNick3
DCNick3 previously approved these changes Jan 15, 2024
@coveralls
Copy link

coveralls commented Jan 15, 2024

Pull Request Test Coverage Report for Build 7527153546

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 57.042%

Totals Coverage Status
Change from base Build 7285255818: 1.0%
Covered Lines: 22489
Relevant Lines: 39425

💛 - Coveralls

Arjentix
Arjentix previously approved these changes Jan 15, 2024
Cargo.toml Show resolved Hide resolved
Cargo.toml Show resolved Hide resolved
Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
@mversic mversic merged commit ce2f0b7 into hyperledger-iroha:iroha2-dev Jan 15, 2024
12 checks passed
@mversic mversic deleted the fix_lints branch January 15, 2024 10:18
mversic added a commit to mversic/iroha that referenced this pull request Jan 18, 2024
…-iroha#4201)

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this pull request Jan 18, 2024
…-iroha#4201)

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this pull request Jan 18, 2024
…-iroha#4201)

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this pull request Jan 18, 2024
…-iroha#4201)

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this pull request Jan 22, 2024
…-iroha#4201)

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Signed-off-by: Asem-Abdelhady <asemshawkey@gmail.com>
Asem-Abdelhady pushed a commit to Asem-Abdelhady/iroha that referenced this pull request Feb 9, 2024
…-iroha#4201)

Signed-off-by: Marin Veršić <marin.versic101@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iroha2-dev The re-implementation of a BFT hyperledger in RUST
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants