-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: Propagate RHS type of resolved assignments #1569
Bugfix: Propagate RHS type of resolved assignments #1569
Conversation
…ry and cant be of type StorageRef. Not dereferencing the type causes various issues in later compilation stages. Signed-off-by: xermicus <cyrill@parity.io>
Signed-off-by: xermicus <cyrill@parity.io>
Codecov Report
@@ Coverage Diff @@
## main #1569 +/- ##
==========================================
- Coverage 87.41% 87.34% -0.08%
==========================================
Files 133 133
Lines 64133 64148 +15
==========================================
- Hits 56063 56029 -34
- Misses 8070 8119 +49
|
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
I changed the fix to use the RHS type of the assignment. Which seems to fix a bunch of cases (see codegen tests). The |
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
Signed-off-by: Cyrill Leutwiler <bigcyrill@hotmail.com>
When resolving an assignment, the resolved variable should inherit the RHS type to avoid various issues in later compilation stages (for example with assignment chains).